updating core in preparation of release #7283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/prepare-release-jan19
branch
from
5793bdb to
9d69309
Compare
codeboten
requested review from
alolita,
Aneurysm9,
anuraaga,
arminru,
bogdandrutu,
dashpole,
djaglowski,
dmitryax,
jmacd,
jpkrohling,
jsuereth,
mx-psi and
punya
as code owners
|
The prometheus compliance tests are failing because of the removal of the |
mx-psi
reviewed
Jan 20, 2022
| @@ -115,7 +115,7 @@ type templateContext struct { | |||
| } | |||
|
|
|||
| func loadMetadata(filePath string) (metadata, error) { | |||
There was a problem hiding this comment.
I think it is cleaner if file: is added inside loadMetadata instead of when you call it, otherwise the filePath argument name is misleading.
There was a problem hiding this comment.
good catch, updated 👍
mx-psi
approved these changes
Jan 20, 2022
bogdandrutu
approved these changes
Jan 20, 2022
added 6 commits
January 21, 2022 12:55
update calls in: exporter/dynatrace exporter/signalfx exporter/zipkin extension/httpforwarder receiver/awscontainerinsight receiver/cloudfoundry exporter/jaegerthrifthttp exporter/sumologic extension/ecstaskobserver processor/resourcedetectionprocessor receiver/awsecscontainermetrics exporter/humio exporter/influxdb exporter/prometheusremotewrite
codeboten
force-pushed
the
codeboten/prepare-release-jan19
branch
from
5b8cff7 to
b3dd438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating core required a bunch of changes to pass
TelemetrySettingsintoToClient. Those are the only changes made outside of runningmake update-otel